Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
/admin/clusters/{cluster_name}/activateand/admin/clusters/{cluster_name}/deactivaterespectively. For this to work you need to authenticate yourself at trino-lb via basic auth (#95)./admin/clusters/{cluster_name}/statusand/admin/clusters/status(#95).This is used to update the segments ackUris to, as sometimes Trino get's confused and put's the wrong endpoint (namely the one of trino-lb) in there.
Please note that this runs a database migration on Postgres (#100).
Changed
TrinoClusterhas changed toreadymore than 5 secondsago before marking it as
ready(#68).0.0.0.0) instead of IPv6 (::).On most Linux systems, binding to
::dual-stacks, on Windows this would likely bind to IPv6 only.As a user reported that they run into
Address family not supported by protocol (os error 97), we now only bind to IPv4.There was some attempt to make it portable work on IPv4 and IPv6 (optional), but that turned out to be a bigger story for later (#91).
Fixed
nextUriand are in stateFINISHED(#98)./v1/statement/executing/{queryId}/{slug}/{token}.Previously, we would GET (instead of HEAD) the URL at the Trino cluster, which resulted in trino-lb dropping the HTTP body, causing problems (#100).